From 2bd6eae82897a0f0a3b739413532848d4e2a3e8e Mon Sep 17 00:00:00 2001 From: Taka Date: Wed, 14 Oct 2020 08:21:42 +0000 Subject: [PATCH] Fixed external links in the help. --- vasl_templates/main_window.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/vasl_templates/main_window.py b/vasl_templates/main_window.py index ec50cdb..7d4f453 100644 --- a/vasl_templates/main_window.py +++ b/vasl_templates/main_window.py @@ -30,7 +30,11 @@ class AppWebPage( QWebEnginePage ): if url.host() in ("localhost","127.0.0.1"): return True if not is_mainframe: - return True # nb: we get here if we're in a child frame (e.g. Google Maps) + # NOTE: We get here if we're in a child frame (e.g. Google Maps). However, we can't just ignore + # these requests, because the help is also in a frame, and we want links to open in an external browser. + # Sigh... + if "google.com/maps" in url.url(): + return True QDesktopServices.openUrl( url ) return False